TCA-1179 work on linting issues -> dev #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CA-1179_work-on-linting-issues
…CA-1179_work-on-linting-issues
vas3a
changed the title
testflyjets
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/TCA-1179
In this PR I've worked on fixing the linting issues within the codebase.
This PR handles only the linting issues within typescript source code, the javascript one was previously matched to the linting rules.
I've also manually disabled a few rules that are causing too many issues and have no significant impact on the codebase. I will re-enable those later on, to enforce a more strict policy, but for now, it's just a pain relief:
no-explicit-anyjsx-a11y/click-events-have-key-eventsAdditionally, I've replaced
eslint-plugin-no-nullwitheslint-plugin-unicorn/no-nullwhich allows for a better linting: it allows strict checking but would disallow using the actual value (eg. assigning null). It must allow strict checking for operations with values that define to null (eg. when checking a local/session storage value, if there's no stored value for it, it will returnnull).