Skip to content

TCA-1179 - uncomment linting in circle ci -> dev #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Apr 5, 2023

Re-enables linting steps on CircleCI.

Note: I only uncommented the dev linting. IMO as far as we have linting working OK in dev there's no need to do it in PROD. I might be wrong, nonetheless let me know.

@vas3a vas3a requested review from testflyjets and kkartunov April 5, 2023 07:18
@vas3a vas3a self-assigned this Apr 5, 2023
@vas3a vas3a requested a review from maxtopc April 5, 2023 07:18
Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a spin on dev. My suggestion would be to run it through the first time with no linting errors to be sure it builds then purposely add a linting error and try it again.

@vas3a vas3a merged commit a864f1f into dev Apr 6, 2023
@vas3a vas3a deleted the TCA-1179_re-enable-circle-ci-linting branch April 18, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants