Dev next

[maxceem]

@vikasrohit this PR is for your information and confirmation for new changes in the DEV branch:

1. Fixed issue which has been left from CF18 [$120] Don't let invite user by email if he is already in the team or already invited #234
2. Implementation of general permission methods with refactored copilotAndAbove permission "middleware" to use new general method for the proof of work. See General permission methods #346 for details.

[vikasrohit]

Thanks @maxceem. For the permission logic, do you think the util you have written now, is potentially candidate to be moved to the core library itself so that others can take benefit of the same logic and we have streamlined way to define permissions?

[vikasrohit]

LGTM

[maxceem]

Thanks @maxceem. For the permission logic, do you think the util you have written now, is potentially candidate to be moved to the core library itself so that others can take benefit of the same logic and we have streamlined way to define permissions?

2 of 3 methods don't depend on the DB, so they for sure can be moved to the core library (potentially). Also, I wrote them by keeping in mind that we are trying to implement simmilar methods in Connect App appirio-tech/connect-app#2841.

Anyway, the most important thing is not methods itself, but the format to define permissions. It would be great if we could use the same permission format across all the repos.

So I guess the plan here could be like:

1. use new general methods and unified permission format in the Project Service
2. update general methods to use the same unified permission format in Connect App
3. see how it works, if there any limitations, if it's comfortable to use them, if they are pron to any errors and so on.
4. adjust methods and formats if neccessary
5. move the common permission methods to the core library

[vikasrohit]

Sounds like a plan. Go ahead.