Skip to content

PM-1499 edit copilot request #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Jul 22, 2025

Added new endpoint under"/v5/projects/copilots/requests/:copilotRequestId(\d+)" to allow users to edit existing copilot requests.

@vas3a vas3a requested a review from kkartunov July 22, 2025 10:55

// Only update fields provided in patchData
await copilotRequest.update(_.extend({
data: patchData,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _.extend method is used here, which might not work as intended. Consider using Object.assign or _.assign to merge patchData into the copilotRequest object. _.extend does not deeply merge objects, which might lead to unexpected behavior.

Copy link
Contributor

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kkartunov kkartunov merged commit bd92a3b into develop Jul 23, 2025
1 check passed
@vas3a vas3a deleted the PM-1499_edit-copilot-request branch July 23, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants