Skip to content

Conversation

JimmyRowland
Copy link

No description provided.

@JimmyRowland JimmyRowland marked this pull request as draft June 23, 2022 21:21
@toplenboren toplenboren marked this pull request as ready for review June 23, 2022 23:18
Copy link
Owner

@toplenboren toplenboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add tests and this feature would go into new release :-)

Thanks for the PR

@@ -4,6 +4,8 @@ const path = require("path")

const { version: packageVersion } = require('./package.json');

// eslint-disable-next-line no-unused-vars
const fsMock = jest.mock('fs')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fsMock needs to be in scope so that mockFsImplementation() can work properly.

@JounQin
Copy link
Collaborator

JounQin commented Apr 7, 2025

@JimmyRowland Sorry, but could you do a rebase to resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants