Skip to content

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Mar 25, 2024

partial fix of #1522

@nathanielsimard nathanielsimard requested a review from louisfd March 25, 2024 19:50
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 86.64122% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 86.33%. Comparing base (8d37884) to head (bcf79db).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/burn-tch/src/bridge.rs 0.00% 24 Missing ⚠️
crates/burn-autodiff/src/bridge.rs 93.44% 8 Missing ⚠️
crates/burn-jit/src/bridge.rs 93.93% 2 Missing ⚠️
crates/burn-tensor/src/tensor/activation/base.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
+ Coverage   85.86%   86.33%   +0.47%     
==========================================
  Files         664      680      +16     
  Lines       75487    77639    +2152     
==========================================
+ Hits        64817    67031    +2214     
+ Misses      10670    10608      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor typos and mostly remove a file that was not supposed to be pushed. Otherwise awesome new concept

D,
>(tensor);

// The line bellow does the backend type cast.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below

@@ -0,0 +1,20 @@
2024-03-21 23:11:15 - Neovide panicked with the message 'called `Result::unwrap()` on an `Err` value: Connection(IoError(Custom { kind: Other, error: UnknownError }))'. (File: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.29.10/src/platform_impl/linux/x11/window.rs; Line: 1316, Column: 14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to gitignore

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@nathanielsimard nathanielsimard merged commit 40a26bd into main Mar 26, 2024
@nathanielsimard nathanielsimard deleted the feat/backend-bridge branch March 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants