Skip to content

Conversation

syl20bnr
Copy link
Member

@syl20bnr syl20bnr commented Mar 27, 2024

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

With the addition of the dependency on burn-wgpu to retrieve system information we had a regression where fusion was always enabled for the wgpu benchmark feature.

This PR disables the default feature for burn-wgpu and add the required default dependencies t be able to retrieve the system information.

Testing

cargo run --release --bin burnbench -- run --benches unary --backends wgpu

cargo run --release --bin burnbench -- run --benches unary --backends wgpu-fusion

cargo run --release --bin burnbench -- run --benches unary --backends candle-cpu

cargo build -p backend-comparison

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (9f9b52c) to head (6d6b32a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files         682      682              
  Lines       77849    77849              
==========================================
- Hits        67231    67230       -1     
- Misses      10618    10619       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syl20bnr syl20bnr merged commit 3a1d520 into main Mar 27, 2024
@syl20bnr syl20bnr deleted the fix/backend-comparison-wgpu-without-fusion branch March 27, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants