Add layer norm onnx op support #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggui
commented
Apr 22, 2024
Comment on lines
+103
to
+106
| // TODO: handle self.full_precision | ||
| quote! { | ||
| let #output = self.#field.forward(#input); | ||
| } |
There was a problem hiding this comment.
Was thinking we could match the elem precision and call into_full_precision() but the backendbridge requires the backend to be specified and here this is a generic... so can't do that right now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
+ Coverage 86.41% 86.44% +0.02%
==========================================
Files 694 695 +1
Lines 80676 80885 +209
==========================================
+ Hits 69718 69922 +204
- Misses 10958 10963 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Progress towards #1544
Changes
Added layer norm ONNX op import support
Testing
Added unit tests for codegen and expected outputs