Remove GraphicsAPI generic for WgpuRuntime #1888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks all
script has been executed.Changes
Slightly cheeky PR so bear with me :)
Ran into some annoying trait bounds while trying to do some stuff and rather than just grumble, felt like I could remove this entirely! A WgpuRuntime is a WgpuRuntime - irregardless of what the graphics API is. This is particularly evident with
runtime::init_existing_device()
- it's possible to register a DX12 device, and yet run it on a BurnRuntime which just seems wrong!I understand it's used to manually pick a graphics API, but, you can already do this with
This could also be in RuntimeOptions perhaps, for consistency.
All that said, this is a bit of miscellaneous design change in a PR so thanks for bearing with me :)