Skip to content

Check nonzero stride, dilation and groups #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Check nonzero stride, dilation and groups #2540

merged 3 commits into from
Nov 27, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Nov 26, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fixes #2481

Changes

Added checks for non-zero values in conv, conv transpose, deform conv and unfold.

To keep it simple I left the fields as usize and simply added a custom new method with the checks, but we could eventually hold NonZeroUsize fields instead.

Testing

Added unit tests.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (fe3e43a) to head (c4eea5d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   82.56%   82.51%   -0.05%     
==========================================
  Files         827      828       +1     
  Lines      106855   107121     +266     
==========================================
+ Hits        88226    88395     +169     
- Misses      18629    18726      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laggui laggui merged commit ec6d853 into main Nov 27, 2024
11 checks passed
@laggui laggui deleted the fix/options/nonzero branch November 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conv2d should check if dilation > 0
2 participants