Migrate matmul autotune to macro and fix accelerated #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CMMA availability first
laggui
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
LGTM!
/edit: pinged @nathanielsimard in case I missed something
nathanielsimard
requested changes
Dec 3, 2024
|
Would it be possible to merge this? I'm still hitting the panic on wasm so currently can't upgrade Burn. |
|
@ArthurBrussee should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix matmul autotune by checking for availability in
should_run.Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Should fix ArthurBrussee/brush#53
Changes
Migrates matmul autotune to the macro to clean up the code.
Implements a simple
should_runto check for availability before running accelerated.Testing
Tests passing.