Skip to content

Use float intrinsics for deform_conv2d backward, fix into_data for padded tensors #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

wingertge
Copy link
Contributor

@wingertge wingertge commented Jan 12, 2025

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Uses float intrinsics instead of CAS where available
Fixes into_data for padded tensors by slicing to the expected length before creating the TensorData.

Testing

All tests pass except for remainder on wgpu/spirv, which is still broken due to a driver bug.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 74.25743% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (51b742f) to head (9bbd495).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...urn-jit/src/kernel/conv/deform_conv_transpose2d.rs 74.19% 24 Missing ⚠️
...tes/burn-jit/src/kernel/conv/conv2d/gemm/launch.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   82.91%   82.90%   -0.02%     
==========================================
  Files         843      843              
  Lines      107431   107461      +30     
==========================================
+ Hits        89081    89093      +12     
- Misses      18350    18368      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have missed a comment from debugging

@laggui laggui merged commit c5362a4 into tracel-ai:main Jan 13, 2025
11 checks passed
@wingertge wingertge deleted the fix/into-data-padding branch January 13, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants