Skip to content

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Changes the fusion read kernel to cast literals at compile time, not runtime.

Testing

All tests pass, and issues encountered in https://github.com/ArthurBrussee/brush/tree/spirv have been fixed.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (b9653f5) to head (aea078e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-jit/src/fusion/on_write/io.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
- Coverage   83.64%   83.63%   -0.01%     
==========================================
  Files         826      826              
  Lines      108746   108752       +6     
==========================================
+ Hits        90956    90960       +4     
- Misses      17790    17792       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Just a comment regarding the cubecl wgpu re-exports.

@laggui laggui merged commit 00422c1 into tracel-ai:main Feb 6, 2025
9 checks passed
@wingertge wingertge deleted the fix/fusion-const branch February 6, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants