Floor Node #2792
Merged
Floor Node #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2792 +/- ##
==========================================
+ Coverage 83.67% 83.68% +0.01%
==========================================
Files 832 833 +1
Lines 109524 109605 +81
==========================================
+ Hits 91643 91724 +81
Misses 17881 17881 ☔ View full report in Codecov by Sentry. |
laggui
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for the addition 🙏
Some minor comments, otherwise will be good to go!
We should also mark the op as supported here: https://github.com/tracel-ai/burn/blob/main/crates/burn-import/SUPPORTED-ONNX-OPS.md
antimora
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thank you for taking up this task.
A couple of small changes needed:
- Update the supported ops doc for
floorop:crates/burn-import/SUPPORTED-ONNX-OPS.md - Remove unrelated changes (probably accidentally checked in):
crates/burn-import/onnx-tests/tests/relu/relu.onnxcrates/burn-import/onnx-tests/tests/one_hot/one_hot.onnxcrates/burn-import/onnx-tests/tests/one_hot/one_hot.py
|
Ran the tests this time. 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1714
#1544
Changes
Implemented Floor Node
Testing
Ran run_checks and checked the code separately too.