Fuse gather #2793
Merged
Fuse gather #2793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 83.67% 83.42% -0.26%
==========================================
Files 832 832
Lines 109524 110016 +492
==========================================
+ Hits 91643 91779 +136
- Misses 17881 18237 +356 ☔ View full report in Codecov by Sentry. |
laggui
approved these changes
Feb 11, 2025
Comment on lines
+646
to
+654
| ElemwisePrecision::Bool => get_offset( | ||
| inputs, | ||
| outputs, | ||
| inputs.t_u32.index(pos), // TODO | ||
| index, | ||
| range, | ||
| config, | ||
| None, | ||
| ), |
There was a problem hiding this comment.
Leave it as todo!() instead? Or match the bool dtype?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added indexed tensor ids to keep track of tensors that can't be accessed using the same vectorization factor as other fused operations.