Proposal to expose ATOL/RTOL defaults #2824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggui
reviewed
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
+ Coverage 81.70% 82.22% +0.51%
==========================================
Files 852 853 +1
Lines 114337 113444 -893
==========================================
- Hits 93424 93275 -149
+ Misses 20913 20169 -744 ☔ View full report in Codecov by Sentry. |
zlogic
pushed a commit
to zlogic/burn
that referenced
this pull request
Feb 19, 2025
* Proposal to expose ATOL/RTOL defaults * Review * flip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#2823
Changes
Exposes the defaults for is_close/all_close atol/rtol to tooling.
Testing
Added tests in close.rs