Fixed GroupNorm implementation #2945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run-checks all
script has been executed.Related Issues/PRs
None
Changes
I discovered that GroupNorm was providing different outputs for the same input as the PyTorch version. The math error was relatively minor, but after this change it now matches the pytorch documentation, and the deviation I experienced in higher-level tests vs pytorch has been resolved.
I also had to tweak the expected test results in InstanceNorm slightly, as it uses GroupNorm internally.
Testing
The cargo tests for burn-core pass with this, and the observed higher-level deviation between my implementation of RWKV and the official pytorch implementation has been resolved.