Skip to content

Chore/fixes #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

Chore/fixes #3114

merged 6 commits into from
Apr 29, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Apr 29, 2025

  • Removed a print introduced in Refactor CubeCL slices #3104
  • Adjusted conv2d_should_match_reference_backend_bias_regression tolerance for something more reasonable
  • Disabled crates cache on linux-std (stable) runner
    • With all the ongoing changes we end up with a bloated cache and have to delete it over again. The tests take ~6min more without all the cached crates, but much more convenient to avoid CI failure so I think the benefits outweigh the cost.

@laggui laggui mentioned this pull request Apr 29, 2025
2 tasks
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (4360f36) to head (c1f7262).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
- Coverage   81.08%   81.04%   -0.04%     
==========================================
  Files         817      817              
  Lines      117326   117407      +81     
==========================================
+ Hits        95131    95158      +27     
- Misses      22195    22249      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit acb2f9b into main Apr 29, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the chore/fixes branch April 29, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants