Skip to content

Replace some powf->powi #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Replace some powf->powi #3152

merged 2 commits into from
May 6, 2025

Conversation

ArthurBrussee
Copy link
Contributor

Changes

Replace some powf -> powi calls. This isn't any faster currently, but could be in the future if powi is specialized.

@ArthurBrussee ArthurBrussee marked this pull request as ready for review May 5, 2025 19:22
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the macos runner isn't picking up the job because other runners are already hanging.. looks like it might have something to do with the new cubecl config.

Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (5a437b0) to head (31c00ad).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-core/src/optim/rmsprop.rs 66.66% 1 Missing ⚠️
crates/burn-tensor/src/tensor/api/numeric.rs 66.66% 1 Missing ⚠️
crates/burn-tensor/src/tensor/ops/int_tensor.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
+ Coverage   81.32%   81.34%   +0.01%     
==========================================
  Files         817      818       +1     
  Lines      117804   117827      +23     
==========================================
+ Hits        95802    95842      +40     
+ Misses      22002    21985      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laggui laggui merged commit 7e547c4 into tracel-ai:main May 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants