Add support onnx instance norm #3177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3177 +/- ##
==========================================
+ Coverage 82.14% 82.19% +0.04%
==========================================
Files 956 962 +6
Lines 121842 122340 +498
==========================================
+ Hits 100090 100559 +469
- Misses 21752 21781 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ONNX InstanceNormalization by integrating it throughout the IR, conversion, codegen, and tests. Key changes include:
- Adding a new InstanceNormalization branch in rank inference and node modules.
- Implementing InstanceNorm configuration and code generation in onnx-ir and burn-import.
- Integrating InstanceNormalization tests and updating documentation and build scripts.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/onnx-ir/src/rank_inference.rs | Added InstanceNormalization handling in rank inference |
| crates/onnx-ir/src/node/mod.rs | Registered new instance_norm module |
| crates/onnx-ir/src/node/instance_norm.rs | Introduced InstanceNormConfig and its tests |
| crates/onnx-ir/src/from_onnx.rs | Added InstanceNormalization conversion logic |
| crates/burn-import/src/onnx/to_burn.rs | Integrated InstanceNorm conversion into the Burn graph conversion |
| crates/burn-import/src/burn/node/mod.rs | Registered InstanceNorm in the burn node enum |
| crates/burn-import/src/burn/node/instance_norm.rs | Implemented InstanceNorm node codegen and serialization |
| crates/burn-import/onnx-tests | Added InstanceNormalization onnx tests (1d, 2d, and 3d) |
| crates/burn-import/SUPPORTED-ONNX-OPS.md | Updated InstanceNormalization support status |
| for (key, value) in node.attrs.iter() { | ||
| match key.as_str() { | ||
| "epsilon" => epsilon = value.clone().into_f32(), | ||
| _ => panic!("Unexpected attribute for InstanceNorm: {key}"), |
There was a problem hiding this comment.
Consider handling unexpected attributes in InstanceNorm more gracefully, for example by logging a warning or returning an error instead of panicking, to improve robustness.
Copilot uses AI. Check for mistakes.
antimora
approved these changes
May 10, 2025
Helios113
pushed a commit
to Helios113/burn
that referenced
this pull request
Jul 1, 2025
* feat: support onnx instance norm * fix: fix ci * fix: fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
#1714, #673
Changes
Adding InstanceNorm onnx support
Testing
Added tests for 1d, 2d and 3d