Skip to content

bump zip dependency + clippy + fmt #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

swfsql
Copy link
Contributor

@swfsql swfsql commented May 15, 2025

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fixes #3198

Changes

Bumped zip to 3.0.0.

Also ran clippy and fmt fixes.

Ps. some clippy warnings were about enum variants sizes, suggesting putting some of them in a Box. I attached an #[allow] for those.

Testing

I haven't locally tested the new version, and I hope the CI checks it.

Some clippy warnings were about enum variants sizes, suggesting putting
some of them in a Box. I attached an #[allow] for those.
@swfsql swfsql mentioned this pull request May 15, 2025
2 tasks
@swfsql swfsql force-pushed the zip-version-bump branch from e13a7f5 to 24619f3 Compare May 15, 2025 20:49
@swfsql
Copy link
Contributor Author

swfsql commented May 15, 2025

My cargo run-checks got the following errors:

failures:

---- tests::cube::kernel::normal::tests::normal_respects_68_95_99_rule stdout ----

thread 'tests::cube::kernel::normal::tests::normal_respects_68_95_99_rule' panicked at /home/thiago/.cargo/git/checkouts/cubecl-058c47895211d464/6ebfb95/crates/cubecl-random/src/tests_utils.rs:27:15:
index out of bounds: the len is 6 but the index is 6

---- tests::cube::tensor::f32_ty::remainder::tests::should_have_no_remainder stdout ----

thread 'tests::cube::tensor::f32_ty::remainder::tests::should_have_no_remainder' panicked at crates/burn-wgpu/src/lib.rs:129:5:
Tensors are not approx eq:
  => Position 4: 0.5034 != 0
     diff (rel = +1.00e0, abs = +5.03e-1), tol (rel = +7.63e-6, abs = +1.88e-37)

---- tests::cube_fusion::tensor::f32_ty::remainder::tests::should_have_no_remainder stdout ----

thread 'tests::cube_fusion::tensor::f32_ty::remainder::tests::should_have_no_remainder' panicked at crates/burn-wgpu/src/lib.rs:129:5:
Tensors are not approx eq:
  => Position 4: 0.5034 != 0
     diff (rel = +1.00e0, abs = +5.03e-1), tol (rel = +7.63e-6, abs = +1.88e-37)


failures:
    tests::cube::kernel::normal::tests::normal_respects_68_95_99_rule
    tests::cube::tensor::f32_ty::remainder::tests::should_have_no_remainder
    tests::cube_fusion::tensor::f32_ty::remainder::tests::should_have_no_remainder

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (508f002) to head (24619f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3199      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.01%     
==========================================
  Files         962      962              
  Lines      122542   122541       -1     
==========================================
+ Hits       100727   100744      +17     
+ Misses      21815    21797      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora antimora merged commit d3caf48 into tracel-ai:main May 16, 2025
11 checks passed
@antimora
Copy link
Collaborator

Filed an issue to take care of large fields: #3202

@antimora
Copy link
Collaborator

@swfsql Thank you for the fix and testing!

Helios113 pushed a commit to Helios113/burn that referenced this pull request Jul 1, 2025
* clippy and fmt fix

Some clippy warnings were about enum variants sizes, suggesting putting
some of them in a Box. I attached an #[allow] for those.

* bump zip version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zip 2.6.1 is yanked
2 participants