-
Notifications
You must be signed in to change notification settings - Fork 645
bump zip dependency + clippy + fmt #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some clippy warnings were about enum variants sizes, suggesting putting some of them in a Box. I attached an #[allow] for those.
My
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
==========================================
+ Coverage 82.19% 82.21% +0.01%
==========================================
Files 962 962
Lines 122542 122541 -1
==========================================
+ Hits 100727 100744 +17
+ Misses 21815 21797 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Filed an issue to take care of large fields: #3202 |
@swfsql Thank you for the fix and testing! |
* clippy and fmt fix Some clippy warnings were about enum variants sizes, suggesting putting some of them in a Box. I attached an #[allow] for those. * bump zip version
Pull Request Template
Checklist
cargo run-checks
command has been executed.Related Issues/PRs
Fixes #3198
Changes
Bumped zip to 3.0.0.
Also ran clippy and fmt fixes.
Ps. some clippy warnings were about enum variants sizes, suggesting putting some of them in a Box. I attached an #[allow] for those.
Testing
I haven't locally tested the new version, and I hope the CI checks it.