Skip to content

burn-import: import derive_new::new for safetensors feat #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

swfsql
Copy link
Contributor

@swfsql swfsql commented May 16, 2025

Pull Request Template

Checklist

  • [n/a] Confirmed that cargo run-checks command has been executed.
  • [n/a] Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Changes

Depending on burn-import with only the safetensors feat causes a build failure.
The fix is a one-line change to import it on the safetensors feat.

Testing

The build succeeds.

@swfsql swfsql changed the title Import derive_new::new for safetensors feat burn-import: import derive_new::new for safetensors feat May 16, 2025
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (63c6528) to head (2288420).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   82.21%   82.22%           
=======================================
  Files         962      962           
  Lines      122582   122582           
=======================================
+ Hits       100785   100788    +3     
+ Misses      21797    21794    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathanielsimard nathanielsimard merged commit 11bbb11 into tracel-ai:main May 20, 2025
32 of 35 checks passed
Helios113 pushed a commit to Helios113/burn that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

burn-import with only safetensors feat fails to build
3 participants