Skip to content

Conversation

laggui
Copy link
Member

@laggui laggui commented May 30, 2025

Checklist

  • Confirmed that cargo run-checks command has been executed.

Related Issues/PRs

Follow-up to changes in #3197

See also CI failures that just happened on main (unrelated to last merged changes)

  thread 'tests::cube::kernel::conv_transpose2d::tests::conv_transpose2d_should_match_reference_backend' panicked at /Users/admin/actions-runner/_work/burn/burn/crates/burn-cubecl/src/tensor/base.rs:53:26:
  Tensors are not approx eq:
    => Position 3057: -0.0000141859055 != -0.000014565485
       diff (rel = +2.61e-2, abs = +3.80e-7), tol (rel = +1.00e-2, abs = +7.52e-37)

Changes

Relative tolerances were adjusted for different modes in a previous PR, but the absolute tolerance was too strict. For values near zero, approximate floating-point comparison should have less strict absolute tolerance.

@laggui laggui requested a review from nathanielsimard May 30, 2025 15:22
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (24e0ca8) to head (851c774).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tensor/src/tensor/data.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3242      +/-   ##
==========================================
+ Coverage   82.13%   82.14%   +0.01%     
==========================================
  Files         966      970       +4     
  Lines      123319   123536     +217     
==========================================
+ Hits       101287   101482     +195     
- Misses      22032    22054      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laggui laggui merged commit 7b6ca82 into main May 30, 2025
11 checks passed
@laggui laggui deleted the fix/tolerance-abs-defaults branch May 30, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants