Skip to content

Perf/fusion deadcode #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 10, 2025
Merged

Perf/fusion deadcode #3263

merged 12 commits into from
Jun 10, 2025

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Jun 6, 2025

Added the Drop operation that can be fused, eliminating some writes in fused kernels, properly propagating dead code elimination. We could apply a dead code elimination algorithm inside of burn-fusion as well in the future to reduce even more computations that are not necessary, but this is a good start.

Uses CubeCL : tracel-ai/cubecl#712

@nathanielsimard nathanielsimard requested a review from laggui June 6, 2025 16:14
@nathanielsimard nathanielsimard marked this pull request as draft June 6, 2025 16:21
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (c9dce9b) to head (97128cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   82.33%   82.30%   -0.03%     
==========================================
  Files         978      978              
  Lines      124869   124870       +1     
==========================================
- Hits       102808   102776      -32     
- Misses      22061    22094      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathanielsimard nathanielsimard marked this pull request as ready for review June 9, 2025 18:57
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment, otherwise it looks pretty good!

Makes more sense now that we don't have to handle orphans across different backends / extensions 😅

@nathanielsimard nathanielsimard merged commit fb6be2b into main Jun 10, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the perf/fusion-deadcode branch June 10, 2025 13:00
Helios113 pushed a commit to Helios113/burn that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants