-
Notifications
You must be signed in to change notification settings - Fork 645
Perf/fusion deadcode #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf/fusion deadcode #3263
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
- Coverage 82.33% 82.30% -0.03%
==========================================
Files 978 978
Lines 124869 124870 +1
==========================================
- Hits 102808 102776 -32
- Misses 22061 22094 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor comment, otherwise it looks pretty good!
Makes more sense now that we don't have to handle orphans across different backends / extensions 😅
Added the Drop operation that can be fused, eliminating some writes in fused kernels, properly propagating dead code elimination. We could apply a dead code elimination algorithm inside of burn-fusion as well in the future to reduce even more computations that are not necessary, but this is a good start.
Uses CubeCL : tracel-ai/cubecl#712