Lazy tensor downloading in burn-remote #3276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3276 +/- ##
==========================================
+ Coverage 82.51% 82.66% +0.14%
==========================================
Files 990 995 +5
Lines 127088 127626 +538
==========================================
+ Hits 104865 105500 +635
+ Misses 22223 22126 -97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| _shape: Vec<usize>, | ||
| _dtype: burn_tensor::DType, | ||
| ) -> RouterTensor<Self::Client> { | ||
| let router_tensor = client.register_tensor_data(handle); | ||
| unimplemented!(); |
| } | ||
|
|
||
| impl RemoteTensorHandle { | ||
| pub(crate) fn change_backend(mut self, target_device: &WsDevice) -> Self { |
There was a problem hiding this comment.
I would add comments on the global strategy with the why!
Comment on lines
26
to
35
| pub struct TensorUploadState { | ||
| pub data: TensorData, | ||
| pub total_upload_count: u32, | ||
| pub cur_upload_count: u32, | ||
| } | ||
|
|
||
| pub struct WsServerState { | ||
| pub current_uploads: Mutex<HashMap<TensorId, TensorUploadState>>, | ||
| } | ||
|
|
There was a problem hiding this comment.
I would put that in tensor_data_service.rs
| }; | ||
|
|
||
| // build our application with some routes | ||
| let app = Router::new() | ||
| .route("/response", any(Self::handler_response)) | ||
| .route("/request", any(Self::handler_request)) | ||
| .with_state(state); | ||
| .route("/upload", any(Self::handler_upload)) |
Comment on lines
231
to
241
| let mut upload_state; | ||
| { | ||
| let mut current_uploads = self.state.current_uploads.lock().unwrap(); | ||
| if current_uploads.contains_key(&id) { | ||
| // take the upload out of the hashmap while we download | ||
| upload_state = current_uploads.remove(&id).unwrap(); | ||
| log::info!("Tensor found (id: {id:?})"); | ||
| } else { | ||
| panic!("A tensor was requested (id: {id:?}) that isn't being served"); | ||
| } | ||
| } |
Comment on lines
252
to
255
| if upload_state.total_upload_count != upload_state.cur_upload_count { | ||
| let mut current_uploads = self.state.current_uploads.lock().unwrap(); | ||
| current_uploads.insert(id, upload_state); | ||
| } |
There was a problem hiding this comment.
I would do that during the first lock.
|
|
||
| match msg { | ||
| Message::Binary(bytes) => { | ||
| let data: TensorData = rmp_serde::from_slice(&bytes) |
There was a problem hiding this comment.
TODO: Optimize that at some point.
Comment on lines
53
to
59
| pub fn register_remote_tensor(&self, tensor: TensorNetwork, new_id: TensorId) { | ||
| self.compute_sender | ||
| .send(ProcessorTask::RegisterRemoteTensor(tensor, new_id)) | ||
| .unwrap() | ||
| } | ||
|
|
||
| pub fn upload_tensor(&self, tensor: TensorIr, count: u32) { |
| @@ -61,7 +83,7 @@ impl<B: BackendIr> Stream<B> { | |||
|
|
|||
| self.compute_sender | |||
| .send(ProcessorTask::Sync(id, callback_sender)) | |||
| .unwrap(); | |||
| .unwrap_or_else(|x| println!("{x:?}")); | |||
crates/burn-router/tmp.rs
Outdated
| @@ -0,0 +1,2451 @@ | |||
| mod types { | |||
Co-authored-by: Jonathan Richard <jwric@users.noreply.github.com>
nathanielsimard
approved these changes
Jun 17, 2025
Helios113
pushed a commit
to Helios113/burn
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.