Add onnx SpaceToDepth / DepthToSpace #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tye-singwa
force-pushed
the
onnx-depth-space
branch
2 times, most recently
from
b654cfa to
51073ee
Compare
tye-singwa
force-pushed
the
onnx-depth-space
branch
from
51073ee to
52e8374
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3277 +/- ##
==========================================
+ Coverage 82.33% 82.36% +0.03%
==========================================
Files 978 984 +6
Lines 124869 125445 +576
==========================================
+ Hits 102808 103329 +521
- Misses 22061 22116 +55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just noticed #2464, maybe it make sense to implement it as separate module in burn-core? |
laggui
reviewed
Jun 11, 2025
crates/burn-import/onnx-tests/tests/depth_to_space/depth_to_space.py
Outdated
Show resolved
Hide resolved
crates/burn-import/onnx-tests/tests/space_to_depth/space_to_depth.py
Outdated
Show resolved
Hide resolved
Comment on lines
+31
to
+42
| // Infer static shape based on rank and block size | ||
| let static_shape = tensor.static_shape.clone().map(|shape| { | ||
| let [b, c, h, w] = shape | ||
| .try_into() | ||
| .expect("DepthToSpace: input tensor rank is not 4"); | ||
| vec![ | ||
| b, | ||
| c / (block_size * block_size), | ||
| h * block_size, | ||
| w * block_size, | ||
| ] | ||
| }); |
There was a problem hiding this comment.
Not required, but since this will only be applied if the static shape is available we can keep it :)
There was a problem hiding this comment.
As i see across code, some operators require static shape, this is reason why i added it
laggui
approved these changes
Jun 12, 2025
Helios113
pushed a commit
to Helios113/burn
that referenced
this pull request
Jul 1, 2025
* feat: add support for DepthToSpace onnx node * feat: add support for SpaceToDepth onnx node * fix: ci * fix: add missing SpaceToDepth rank_inference * fix: mark supported onnx nodes * test: fix tests * fix: set opset version to 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
#1714, #2930
Changes
Adding support for SpaceToDepth / DepthToSpace onnx nodes
Testing
Added a bunch of tests