Add onnx ArgMin node #3285
Merged
Add onnx ArgMin node #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tye-singwa
force-pushed
the
onnx-arg-min
branch
2 times, most recently
from
e8a9b28 to
9dd5cf2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
========================================
Coverage 82.36% 82.37%
========================================
Files 984 987 +3
Lines 125439 125627 +188
========================================
+ Hits 103323 103490 +167
- Misses 22116 22137 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laggui
reviewed
Jun 12, 2025
There was a problem hiding this comment.
LGTM!
Just missing the change in SUPPORTED-ONNX-OPS.md 🙂
/edit: ah and the merge conflicts with your other PR that was just merged
|
Thanks for checking, just rebased, added SUPPORTED-ONNX-OPS.md, missed it |
laggui
approved these changes
Jun 12, 2025
Helios113
pushed a commit
to Helios113/burn
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
#1714
Changes
Added ArgMin onnx node same way as ArgMax is implemented right now
Testing
Code covered with tests, including sample
argmin.onnx