Improve RoPE partial shift case #3290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checks
command has been executed.Related Issues/PRs
Follow-up to #3275
Changes
Added a small improvement to only compute the additional values required when shifting. So if the start position is still within the buffer positions, the tail is shifted to the head (slice assign) and only the new values are computed + attributed (slice assigned).
Testing
Added unit tests