Skip to content

Improve RoPE partial shift case #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

laggui
Copy link
Member

@laggui laggui commented Jun 13, 2025

Checklist

  • Confirmed that cargo run-checks command has been executed.

Related Issues/PRs

Follow-up to #3275

Changes

Added a small improvement to only compute the additional values required when shifting. So if the start position is still within the buffer positions, the tail is shifted to the head (slice assign) and only the new values are computed + attributed (slice assigned).

Testing

Added unit tests

@laggui laggui requested a review from nathanielsimard June 13, 2025 18:56
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (0f84161) to head (029910a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3290   +/-   ##
=======================================
  Coverage   82.38%   82.39%           
=======================================
  Files         987      987           
  Lines      125627   125691   +64     
=======================================
+ Hits       103496   103561   +65     
+ Misses      22131    22130    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathanielsimard nathanielsimard merged commit 7a854b0 into main Jun 16, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the feat/rope/shift-partial branch June 16, 2025 14:20
Helios113 pushed a commit to Helios113/burn that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants