Skip to content

Add support onnx size #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Add support onnx size #3301

merged 2 commits into from
Jun 25, 2025

Conversation

tye-singwa
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Added support for onnx Size node

Testing

Added tests

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (304db36) to head (bfb7ef6).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/onnx-ir/src/node/size.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3301      +/-   ##
==========================================
+ Coverage   82.38%   82.65%   +0.26%     
==========================================
  Files         987      996       +9     
  Lines      125627   127678    +2051     
==========================================
+ Hits       103502   105536    +2034     
- Misses      22125    22142      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laggui
Copy link
Member

laggui commented Jun 19, 2025

Been a little busy recently, will have a look at this soon 😅

@laggui laggui self-requested a review June 19, 2025 12:15
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Implementation LGTM 🙂

@laggui laggui merged commit d5677bd into tracel-ai:main Jun 25, 2025
19 of 20 checks passed
@tye-singwa tye-singwa deleted the onnx-size branch June 26, 2025 06:28
Helios113 pushed a commit to Helios113/burn that referenced this pull request Jul 1, 2025
* feat: support onnx size

* test: remove unnecessary args for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants