Skip to content

Conversation

tye-singwa
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Attempt to fix #3264

Changes

Fixed incorrect elem_type inference for Reshape op, previously it always set Float32 from outputs[0]

Testing

Added test, checked on SAM ViT-B

Copy link

codecov bot commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.15%. Comparing base (fb3843e) to head (f072580).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
crates/onnx-ir/src/node/reshape.rs 89.28% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3395       +/-   ##
===========================================
+ Coverage   35.19%   63.15%   +27.95%     
===========================================
  Files         342      963      +621     
  Lines       53164   108455    +55291     
===========================================
+ Hits        18712    68491    +49779     
- Misses      34452    39964     +5512     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tye-singwa tye-singwa marked this pull request as ready for review July 20, 2025 12:45
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fixing the issue!

LGTM

@antimora antimora merged commit 7f3e9c0 into tracel-ai:main Jul 21, 2025
13 checks passed
@tye-singwa tye-singwa deleted the onnx-fix-reshape-rank-inference branch August 9, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONNX Import Fails with "Where" Operator Type Mismatch Error
2 participants