Fix for HumanNameParser incorrectly interprets some name components as postnominals #17
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Hi. While using this library I observed that names similar to the default postnominals such as "Ruvin Phidd" cannot be parsed correctly, throwing the exception
The cause is that the default postnominals
contains periods (.), which are interpreted as wildcard characters when parsed as regular expressions. As a result, unexpected matches occur during name parsing. The fix included on this PR addresses this problem by formatting the default values on the build() step of
HumanNameParserBuilder
.Changes
formatToRegex
toHumanNameParserBuilder
and modified build() to format the default values.testLastNameNotMistakenForPostnominal
atBuilderTest
that catches this problem.