Skip to content

Switch to our svg-sprite fork #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Switch to our svg-sprite fork #631

merged 2 commits into from
Jan 5, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 30, 2020

Not tagged on npm, but it's lighter.

svg-sprite/svg-sprite@master...twbs:dev

We should probably check if there ever is a new upstream release in the future since I don't know if dependabot will notify us, and switch back to that, assuming our patches are sorted there too.

@XhmikosR
Copy link
Member Author

Switching to the upstream master branch might also work, but it seems unmaintained anyway. I didn't bother with publishing this on npm since we can just use the repo branch, but we could do it later if needed.

@XhmikosR XhmikosR force-pushed the svg-sprite branch 3 times, most recently from ae71ecf to 4178e9f Compare December 30, 2020 13:22
@XhmikosR XhmikosR changed the title Switch to our svg-sprite branch Switch to our svg-sprite fork Dec 30, 2020
@XhmikosR XhmikosR force-pushed the svg-sprite branch 9 times, most recently from 4a8b944 to f8b749c Compare January 4, 2021 15:00
@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 4, 2021

I made an upstream PR, maybe it will get merged otherwise we can revisit publishing our fork on npm later

@XhmikosR XhmikosR force-pushed the svg-sprite branch 3 times, most recently from cc3b3f1 to abd889e Compare January 5, 2021 12:24
Fixes a few security issues and plenty of redundant dependencies.

Not tagged on npm, but we can do it later if needed.
@XhmikosR XhmikosR merged commit 433a463 into main Jan 5, 2021
@XhmikosR XhmikosR deleted the svg-sprite branch January 5, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants