Skip to content

Generate font page with Hugo #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Generate font page with Hugo #706

merged 5 commits into from
Aug 28, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 22, 2021

This is for preview purposes currently. We first need to finish with the other PRs.

TODO:

  • Finish with the other PRs
  • Fill description and title
  • Include ads in the layout?
  • Add the font page in a subnav or something? Currently, I have added breadcrumbs only, but the page is not linked from anywhere else
  • If needed, manually clean up the patches before merging

@XhmikosR XhmikosR added the docs Improvements or additions to documentation label Jan 22, 2021
@XhmikosR XhmikosR force-pushed the font-layout branch 4 times, most recently from 11a26dc to a2e8bc7 Compare February 7, 2021 17:41
@XhmikosR XhmikosR mentioned this pull request Feb 8, 2021
2 tasks
@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 8, 2021

@mdo this is mostly ready from my side. I need some help with the remaining TODOs from you

@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 2, 2021

@mdo we should really move with this; it saves us a lot of duplication and currently it's also blocking #824.

@kiehnek
Copy link
Contributor

kiehnek commented Dec 18, 2021

Is an explicit font page really necessary? Isn't it just showing the same as the homepage? I can't really see a use case for this.

I also think that we should try to document the code points properly (#891). They could be included on this page or on the page of an icon.

@XhmikosR
Copy link
Member Author

Well, compared to the crappy looking page we have right now, this looks better. This page serves as a test page to make sure the font is fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants