Skip to content

feat: add .node-version and .nvmrc support #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2024
Merged

feat: add .node-version and .nvmrc support #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fce313
feat: add .nvmrc support
JoshuaKGoldberg Jan 16, 2024
6692271
chore: added changeset
JoshuaKGoldberg Jan 16, 2024
e761be3
feat: also add .node-version
JoshuaKGoldberg Jan 16, 2024
80d336f
Update .changeset/gorgeous-ladybugs-push.md
JoshuaKGoldberg Jan 16, 2024
435825a
fix: remove vscodeLanguageIds
JoshuaKGoldberg Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-ladybugs-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"prettier-plugin-sh": minor
---

feat: add `.node-version` and `.nvmrc` support
10 changes: 10 additions & 0 deletions packages/sh/test/__snapshots__/fixtures.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ node_modules
"
`;

exports[`parser and printer > should format all fixtures > .nvmrc 1`] = `
"v1.2.3
"
`;

exports[`parser and printer > should format all fixtures > .nvmrc 2`] = `
"v1.2.3
"
`;

exports[`parser and printer > should format all fixtures > .properties 1`] = `
"# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
Expand Down
1 change: 1 addition & 0 deletions packages/sh/test/fixtures/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v1.2.3
7 changes: 7 additions & 0 deletions scripts/languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ const EXTRA_SH_LANGUAGES: SupportLanguage[] = [
filenames: ['.env.*'],
vscodeLanguageIds: ['dotenv'],
},
{
name: 'nvmrc',
since: '0.14.0',
parsers: ['sh'],
extensions: ['.node-version', '.nvmrc'],
filenames: ['.node-version', '.nvmrc'],
},
]

const getSupportLanguages = (
Expand Down