fix: restrict {{$randomInt}} output to 0–1000 as per docs (#4847)
#4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#4847) Previously, `{{$randomInt}}` returned values across the full JavaScript number range. This commit updates the generator to produce integers between 0 and 1000, matching the documented behavior. Fixes usebruno#4847
junglesub
requested review from
helloanoop,
maintainer-bruno,
lohit-bruno and
naman-bruno
as code owners
maintainer-bruno
approved these changes
Jun 18, 2025
naman-bruno
approved these changes
Jun 19, 2025
lohit-bruno
approved these changes
Jul 4, 2025
sanish-bruno
pushed a commit
to sanish-bruno/bruno
that referenced
this pull request
Jul 15, 2025
…#4847) (usebruno#4938) Previously, `{{$randomInt}}` returned values across the full JavaScript number range. This commit updates the generator to produce integers between 0 and 1000, matching the documented behavior. Fixes usebruno#4847
sanish-bruno
pushed a commit
to sanish-bruno/bruno
that referenced
this pull request
Jul 15, 2025
…#4847) (usebruno#4938) Previously, `{{$randomInt}}` returned values across the full JavaScript number range. This commit updates the generator to produce integers between 0 and 1000, matching the documented behavior. Fixes usebruno#4847
naman-bruno
pushed a commit
to naman-bruno/bruno
that referenced
this pull request
Jul 17, 2025
…#4847) (usebruno#4938) Previously, `{{$randomInt}}` returned values across the full JavaScript number range. This commit updates the generator to produce integers between 0 and 1000, matching the documented behavior. Fixes usebruno#4847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
🔥 Related Issues
{{$randomInt}}returns unexpected large numbers — doesn't match documented range (0–1000) #4847📷 Screenshot
📝 Description
This PR fixes the behavior of
{{$randomInt}}to align with the documented range of 0 to 1000.Although the maintainer mentioned the range should be 1 to 1000, the current documentation specifies 0 to 1000, so I implemented it accordingly for now.
Additionally, I updated the relevant test cases to reflect the corrected range.
✅ Changes
{{$randomInt}}implementation to return integers between0and1000(inclusive)📌 Note
If the intended range is confirmed to be
1–1000, I’m happy to adjust the implementation accordingly.