Skip to content

Fix: Enhance path validation to include last opened collections #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

Pragadesh-45
Copy link
Contributor

Description

This PR implements a fix for the issue where triggering the new-request action without an open collection results in an error. This issue was introduced in version v2.7.0-2025.07.15 via PR #4800.

The problem occurs because unopened collections are not considered active, so actions like new-request fail when no active collection is available.

This has been fixed by adding lastOpenedCollection to the list of openCollectionPaths, which represents the active collections. If the collection is opened in Bruno, then the new-request action can be performed successfully

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@Pragadesh-45 Pragadesh-45 force-pushed the fix/collection-path-validator branch from 2bc1b7e to 01887c3 Compare July 16, 2025 13:22
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 16, 2025
@Pragadesh-45 Pragadesh-45 force-pushed the fix/collection-path-validator branch from 0639964 to 6eb2e9e Compare July 16, 2025 13:55
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 16, 2025
@lohxt1 lohxt1 merged commit 645b7e7 into usebruno:main Jul 16, 2025
5 of 6 checks passed
naman-bruno pushed a commit to naman-bruno/bruno that referenced this pull request Jul 17, 2025
naman-bruno pushed a commit to naman-bruno/bruno that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants