VATPAC 2505 sector audit #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes are good to me. Just resubmitted the PR because of an excess of conflicts. |
|
Quality job, as always. But I would fix those labels, current it's not clear what sector they belong to. It this is intended, LGTM
|
daniluk4000
requested changes
Jun 4, 2025
Hi Danila - Yep this label placement is intended. The group sector labels are inherited from their primary sector, so will be offset to wherever they are. |
|
The only one I'd disagree with is I'll move TRT (cause currently partially appears in TRS) |
|
otherwise LGTM, send it |
daniluk4000
approved these changes
Jun 6, 2025
Adrian2k
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes to Australian Positions and Identifiers within the YBBB FIR.
Reallocated sector groupings in the Brisbane FIR.
Added sector definition and identifier for YASH
Added sector definition and identifier for YWIL
Fixed AYPM being marked as oceanic
Reason and motivation
Keeping the positions up to date with the internal VATPAC dataset.
Re-made PR based off #970 due conflicts.
Approved contributior?