Skip to content

fix(test-utils): verify object not null for typeof #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix(test-utils): verify object not null for typeof #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server-test-utils/dist/vue-server-test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ function isDynamicComponent(c) {
}

function isComponentOptions(c) {
return typeof c === 'object' && (c.template || c.render)
return c !== null && typeof c === 'object' && (c.template || c.render)
}

function isFunctionalComponent(c) {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function isDynamicComponent(c: any) {
}

export function isComponentOptions(c: any) {
return typeof c === 'object' && (c.template || c.render)
return c !== null && typeof c === 'object' && (c.template || c.render)
}

export function isFunctionalComponent(c: any) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test-utils/dist/vue-test-utils.iife.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1953,7 +1953,7 @@ var VueTestUtils = (function (exports, Vue, vueTemplateCompiler) {
}

function isComponentOptions(c) {
return typeof c === 'object' && (c.template || c.render)
return c !== null && typeof c === 'object' && (c.template || c.render)
}

function isFunctionalComponent(c) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test-utils/dist/vue-test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,7 +1957,7 @@ function isDynamicComponent(c) {
}

function isComponentOptions(c) {
return typeof c === 'object' && (c.template || c.render)
return c !== null && typeof c === 'object' && (c.template || c.render)
}

function isFunctionalComponent(c) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test-utils/dist/vue-test-utils.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1956,7 +1956,7 @@
}

function isComponentOptions(c) {
return typeof c === 'object' && (c.template || c.render)
return c !== null && typeof c === 'object' && (c.template || c.render)
}

function isFunctionalComponent(c) {
Expand Down