-
-
Notifications
You must be signed in to change notification settings - Fork 166
refactor: fs-router to use new_createPages & fix staticPaths #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
745d701
fix: render type test issues with new_createPages
tylersayshi dbf430b
Merge remote-tracking branch 'upstream/main' into refactor-e2e-test-c…
tylersayshi 15931b2
wrong mapping
tylersayshi 0cf6fa6
fix: render type with right mapping
tylersayshi 12c8770
Merge remote-tracking branch 'upstream/main' into refactor-e2e-test-c…
tylersayshi 474adb6
fix: regression to layouts
tylersayshi 48bb258
fix: remove stale comment
tylersayshi bdfec76
refactor: use new_createPages for fs-router
tylersayshi 4500c06
Merge branch 'dai-shi:main' into refactor-fs-router
tylersayshi 8232409
Merge branch 'dai-shi:main' into refactor-fs-router
tylersayshi cd89be0
Merge remote-tracking branch 'upstream/main' into refactor-fs-router
tylersayshi 0a950ad
Merge branch 'main' into refactor-fs-router
dai-shi f7f0887
Merge branch 'main' into refactor-fs-router
dai-shi 4a8723c
try updating rsc managed
tylersayshi 4edcfa9
fix static paths in create pages
tylersayshi b7c6cbd
Merge branch 'main' into refactor-fs-router
tylersayshi a20a274
add test
tylersayshi 26e09b8
logs and refactor of new_createPages
tylersayshi 8586f6b
fix OOM!!!!
tylersayshi 4d51add
Merge remote-tracking branch 'upstream/main' into refactor-fs-router
tylersayshi e187fae
test fixes
tylersayshi 7741c0b
fix complex test
tylersayshi c9bff5d
revert to writeFile from writeFileSync
tylersayshi 27092f9
remove log
tylersayshi 5ab2859
revert rsc-renderer
tylersayshi b412f5f
slice emitStaticFiles parrallelization
tylersayshi 8c04a31
Merge remote-tracking branch 'upstream/main' into refactor-fs-router
tylersayshi e03912c
revert create pages changes
tylersayshi f6e4e05
fix: staticPath items should have matching patterns
tylersayshi 92d3676
fix: Use page path prop for ssg-performance
tylersayshi 81ad79d
Merge branch 'main' into refactor-fs-router
tylersayshi edfc3e1
fix: path and slug name
tylersayshi 15af92b
fix: type import and path as prop for layout
tylersayshi 00e317b
fix: error on [path] file use in fs-router
tylersayshi f8a084e
fix: createLayout type remove hash
tylersayshi 727f65e
Merge remote-tracking branch 'upstream/main' into refactor-fs-router
tylersayshi 0ec5ac6
chore: remove ssg-performance _layout
tylersayshi f132c4f
Revert "chore: remove ssg-performance _layout"
tylersayshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
import { getPath } from './context.js'; | ||
|
||
export function Path() { | ||
return <h1>{getPath()}</h1>; | ||
export function Path({ path }: { path: string }) { | ||
return <h1>{path}</h1>; | ||
} |
This file was deleted.
Oops, something went wrong.
5 changes: 3 additions & 2 deletions
5
...ures/ssg-performance/src/pages/[path].tsx → ...ures/ssg-performance/src/pages/[slug].tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
import type { PropsWithChildren } from 'react'; | ||
import { setPath } from '../context.js'; | ||
|
||
export default function Layout({ | ||
children, | ||
path, | ||
}: PropsWithChildren<{ path: string }>) { | ||
setPath(path); | ||
return children; | ||
export default function Layout({ children }: PropsWithChildren) { | ||
return <div>{children}</div>; | ||
} | ||
tylersayshi marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"name": "waku-example", | ||
"name": "ssg-wildcard", | ||
"version": "0.1.0", | ||
"type": "module", | ||
"private": true, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.