-
-
Notifications
You must be signed in to change notification settings - Fork 166
feat: support catch all on router api #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
a60976a
to
ee4fefd
Compare
review request @hamlim @tylersayshi |
we have some flaky tests I think |
ee4fefd
to
f1003be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable to me, I think we can re-enable this E2E test also:
waku/e2e/wildcard-api-routes.spec.ts
Lines 17 to 21 in 36894d3
// @TODO: re-enable when root wildcard route can match index route - #1518 | |
test.skip('catch all route can match as index route', async ({ page }) => { | |
await page.goto(`http://localhost:${port}/`); | |
await expect(page.getByText('Catch All Pages Route')).toBeVisible(); | |
}); |
nice catch |
133b367
to
020a522
Compare
going to merge this tmr if no upcoming comment |
I'll merge this. @tylersayshi Please be aware of this change. |
Fixes: #1518