Skip to content

Conversation

himself65
Copy link
Member

Fixes: #1518

Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Aug 1, 2025 3:27am

Copy link

codesandbox-ci bot commented Jul 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jul 31, 2025

Open in StackBlitz

npm i https://pkg.pr.new/wakujs/waku@1573

commit: 9bbb443

@dai-shi
Copy link
Member

dai-shi commented Jul 31, 2025

review request @hamlim @tylersayshi

@himself65
Copy link
Member Author

himself65 commented Jul 31, 2025

we have some flaky tests I think

Copy link
Contributor

@hamlim hamlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me, I think we can re-enable this E2E test also:

// @TODO: re-enable when root wildcard route can match index route - #1518
test.skip('catch all route can match as index route', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByText('Catch All Pages Route')).toBeVisible();
});

@himself65
Copy link
Member Author

Changes seem reasonable to me, I think we can re-enable this E2E test also:

// @TODO: re-enable when root wildcard route can match index route - #1518
test.skip('catch all route can match as index route', async ({ page }) => {
await page.goto(`http://localhost:${port}/`);
await expect(page.getByText('Catch All Pages Route')).toBeVisible();
});

nice catch

@himself65 himself65 force-pushed the himself65/2025/07/30/catch-all branch from 133b367 to 020a522 Compare July 31, 2025 20:16
@himself65
Copy link
Member Author

going to merge this tmr if no upcoming comment

@dai-shi
Copy link
Member

dai-shi commented Aug 1, 2025

I'll merge this.

@tylersayshi Please be aware of this change.

@dai-shi dai-shi merged commit e346d6c into wakujs:main Aug 1, 2025
48 of 49 checks passed
@dai-shi dai-shi mentioned this pull request Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow /[...catchAll] routes to handle / (index) routes
3 participants