Skip to content

Add MDX package #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Add MDX package #7312

merged 3 commits into from
Oct 23, 2018

Conversation

jonsuh
Copy link
Contributor

@jonsuh jonsuh commented Oct 3, 2018

Syntax highlighting support for MDX (.mdx) files.

Package: https://github.com/jonsuh/mdx-sublime

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: MDX Syntax Highlighting

Packages added:
  - MDX Syntax Highlighting

Processing package "MDX Syntax Highlighting"
  - All checks passed

@jonsuh jonsuh mentioned this pull request Oct 3, 2018
7 tasks
@Thom1729
Copy link
Collaborator

I'd recommend a somewhat different implementation for the syntax. You should be able to use embed to highlight the JavaScript/JSX rather than duplicating the logic. I'd recommend using JS Custom (which I wrote) as the baseline, because babel-sublime is quite old and buggy.

@Thom1729 Thom1729 merged commit 89264dd into wbond:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants