Add option to ignore class member implementations #1174
+128
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment, abstract class members that have an implementation are never detected as unused because the implementation itself is returned in the references for the abstract class member.
In this example, neither
unused
method would be detected as unused.Changes
This PR adds the
ignoreClassMemberImplementations
option as well as the--ignore-class-member-implementations
CLI flag.When enabled, implementations are ignored when looking for references of class members, allowing for the removal of unused class members which are never directly referenced.
In the previous example, only
AbstractClass.unused
would be detected as unused at first. If it is removed, thenExtendedClass.unused
would be detected as unused.