Skip to content

Create GraphQL project #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Create GraphQL project #1334

wants to merge 9 commits into from

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jul 18, 2025

No description provided.

@StefH StefH requested a review from Copilot July 18, 2025 11:53
@StefH StefH self-assigned this Jul 18, 2025
@StefH StefH added the feature label Jul 18, 2025
Copilot

This comment was marked as outdated.

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.86%. Comparing base (c32e904) to head (f01341d).

Files with missing lines Patch % Lines
...rc/WireMock.Net.Minimal/RequestBuilders/Request.cs 50.00% 5 Missing ⚠️
...ireMock.Net.Minimal/Serialization/MatcherMapper.cs 58.33% 5 Missing ⚠️
...ireMock.Net.Minimal/Models/GraphQLSchemaDetails.cs 60.00% 2 Missing ⚠️
...Mock.Net.Minimal/Serialization/MappingConverter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
- Coverage   37.16%   35.86%   -1.31%     
==========================================
  Files         176      170       -6     
  Lines       40861    39341    -1520     
==========================================
- Hits        15187    14109    -1078     
+ Misses      25250    24645     -605     
- Partials      424      587     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@StefH StefH requested a review from Copilot July 18, 2025 15:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates a new separate GraphQL project by extracting GraphQL functionality from the main WireMock.Net project into a dedicated WireMock.Net.GraphQL assembly. This modularization allows the GraphQL functionality to be an optional dependency rather than being bundled with the core library.

  • Extracted GraphQL-related classes and interfaces into a new WireMock.Net.GraphQL project
  • Replaced direct GraphQL.Types.ISchema usage with a new ISchemaData abstraction
  • Refactored GraphQL functionality to use dynamic loading through TypeLoader pattern

Reviewed Changes

Copilot reviewed 32 out of 39 changed files in this pull request and generated 2 comments.

File Description
src/WireMock.Net.GraphQL/ New GraphQL project with matchers, models, and extension methods
src/WireMock.Net.Shared/ Added TypeLoader utility and IGraphQLMatcher interface
src/WireMock.Net.Minimal/ Updated serialization and removed embedded GraphQL functionality
test/ Updated test references to use new GraphQL interfaces and namespaces
Comments suppressed due to low confidence (2)

src/WireMock.Net.Minimal/Util/TypeLoader.cs:13

  • The class name 'TypeLoader2' is unclear and suggests this is a temporary or duplicate implementation. Consider using a more descriptive name that indicates its purpose or relationship to the original TypeLoader.
internal static class TypeLoader2

src/WireMock.Net.Shared/Util/TypeLoader.cs:15

  • The variable name 'Assemblies' is misleading as it stores Type objects, not Assembly objects. Consider renaming to 'TypeCache' or 'CachedTypes' to better reflect its contents.
    private static readonly ConcurrentDictionary<string, Type> Assemblies = new();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant