-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
tutorial: update hamburger component to use button element #12171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thanks for snagging the issue! Just noting that after this specific code is finalized, we need to:
|
I just checked and in this repository there are no other changes besides the i18n one. I’m not sure if I should update it since it will be marked as updated if I make the change. I’ll make the change in the repo you shared with me |
Just answering this here as sometimes people use past PRs for reference or guidance!
Just like our PR template says, changes should only be made in one language. If we're changing the English content, we don't want any other translations changed. (And, in the rare situations where this might be helpful, we will say so and ask for it to be added alongside the English content.) |
Thanks @bjohansebas, since we are already improving accessibility, I believe we can go all the way and get the most accessible implementation. Could you follow this article along and match the implementation? I believe all the changes needed will be:
|
Hey, I made several changes to the template (withastro/blog-tutorial-demo#44), please review them and I’ll make the content changes here once we’re in agreement. |
Description (required)
The hamburger component example was updated to use a button, and some classes were added to make it like the original, since by default buttons have certain styles that depend on the browser/operating system
Related issues & labels (optional)