Workaround for libxml double-free in PHP 8.1.21 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codders
force-pushed
the
bugfix/workaround-libxml-issue-20250711
branch
from
8886044 to
faf6aa7
Compare
There is a quirky behaviour of the libxml integration in PHP 8.1.21 that results in "DOMException: Not Found Error" or in some cases a SEGFAULT when nodes are appended to the DOM adjacent to nodes that are being / have been removed from the DOM. While we wait for our infrastructure (and especially mwcli (T388411)) to move away from the version that has the bug, add a workaroud so that we can make progress with MEX development. Bug: T398821
codders
force-pushed
the
bugfix/workaround-libxml-issue-20250711
branch
from
faf6aa7 to
7c3dcd8
Compare
lucaswerkmeister
approved these changes
Jul 11, 2025
Comment on lines
+163
to
+165
| foreach ( $children as $child ) { | ||
| $parent->appendChild( $child ); | ||
| } |
There was a problem hiding this comment.
$parent->append( ...$children ); also seems to work FWIW (tested on PHP 8.4.10 and 8.1.18).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a quirky behaviour of the libxml integration in PHP 8.1.21 that results in "DOMException: Not Found Error" or in some cases a SEGFAULT when nodes are appended to the DOM adjacent to nodes that are being / have been removed from the DOM.
While we wait for our infrastructure (and especially mwcli (T388411)) to move away from the version that has the bug, add a workaround so that we can make progress with MEX development.
Bug: T398821