-
Notifications
You must be signed in to change notification settings - Fork 103
Convert CREATE INDEX SQL into pgroll operation #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
commented
Dec 19, 2024
5469ddc
to
d912b21
Compare
d912b21
to
c272662
Compare
I think this is good to go now @ryanslade. Changes I made:
I also made #565 to simplify the use of the This PR is now stacked on: |
Nice! The two PRs lower in the stack look good so we can merge those into |
65b7013
to
eed8227
Compare
c272662
to
8fbd1b2
Compare
Convert `CREATE INDEX` statements to `OpCreateIndex` operations. Supported SQL statements: ```sql CREATE INDEX idx_name ON foo (bar) CREATE INDEX idx_name ON foo (bar ASC) CREATE INDEX idx_name ON foo USING btree (bar) CREATE INDEX idx_name ON foo USING brin (bar) CREATE INDEX idx_name ON foo USING gin (bar) CREATE INDEX idx_name ON foo USING gist (bar) CREATE INDEX idx_name ON foo USING hash (bar) CREATE INDEX idx_name ON foo USING spgist (bar) CREATE INDEX CONCURRENTLY idx_name ON foo (bar) CREATE INDEX idx_name ON schema.foo (bar) CREATE INDEX idx_name ON foo (bar, baz) CREATE UNIQUE INDEX idx_name ON foo (bar) CREATE INDEX idx_name ON foo (bar) WHERE (foo > 0) CREATE INDEX idx_name ON foo (bar) WHERE foo > 0 CREATE INDEX idx_name ON foo (bar) WITH (fillfactor = 70) CREATE INDEX idx_name ON foo (bar) WITH (deduplicate_items = true) CREATE INDEX idx_name ON foo (bar) WITH (buffering = ON) CREATE INDEX idx_name ON foo (bar) WITH (buffering = OFF) CREATE INDEX idx_name ON foo (bar) WITH (buffering = AUTO) CREATE INDEX idx_name ON foo (bar) WITH (fastupdate = true) CREATE INDEX idx_name ON foo (bar) WITH (pages_per_range = 100) CREATE INDEX idx_name ON foo (bar) WITH (autosummarize = true) CREATE INDEX idx_name ON foo (bar) WITH (fillfactor = 70, deduplicate_items = true) ```
8fbd1b2
to
0335e7b
Compare
andrew-farries
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the majority of
CREATE INDEX
statements intoOpCreateIndex
The following cases are covered:
And the following unsupported cases fall back to RAW SQL: