Add support for alter_table set NOT NULL operations with rename_column operations
#607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Jan 20, 2025
Use the physical column name when dropping the temporary column during rollback. This ensures that the correct column is dropped, even if the column was renamed by a previous operation.
Use the physical column name instead of a name derived from the name given by the operation when adding a `NOT NULL` constraint. This ensures that the correct column name is used even if the column has been renamed by a previous rename operation in the same migration.
Allow specifying the name of the duplicated column, overriding the default name.
When duplicating the column, use the name of the column taken from the operation instead of the name of the column in the schema. This ensures that the `Complete` method can find the duplicated column under the name that it expects.
Update the in memory schema on completion so that the virtual schema reflects the column rename. This allows subsequent Complete steps in other operations to see the column rename.
Add the new column to the in-memory schema so that Complete steps in subsequent operations can see the new column.
andrew-farries
force-pushed
the
support-rename-column-set-not-null
branch
from
508a839 to
60e201c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that multi-operation migrations combining
alter_columnSET NOT NULLandrename_columnoperations work as expected.{ "name": "06_multi_operation", "operations": [ { "rename_column": { "table": "items", "from": "name", "to": "item_name" } }, { "alter_column": { "table": "items", "column": "item_name", "nullable": false, "up": "SELECT CASE WHEN item_name IS NULL THEN 'anonymous' ELSE item_name END", "down": "item_name || '_from_down_trigger'" } } ] }This migration renames a column and then sets the renamed column's
nullability.Previously the migration would fail as the
alter_columnoperation was unaware of the changes made by the preceding operation.Part of #239