Add support for alter_table set unique operations in multi-operation migrations
#609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Jan 20, 2025
andrew-farries
force-pushed
the
support-create-table-set-not-null
branch
from
03f78a6 to
632f47c
Compare
andrew-farries
force-pushed
the
support-set-unique-in-multi-op-migrations
branch
from
ddddd4a to
ac327e7
Compare
andrew-farries
force-pushed
the
support-create-table-set-not-null
branch
from
632f47c to
ce2b4dd
Compare
andrew-farries
force-pushed
the
support-set-unique-in-multi-op-migrations
branch
from
ac327e7 to
57a9386
Compare
Ensure that a column on a table that has been renamed by a previous operation can be made unique.
When setting a unique constraint on a column, take the table and column name from the in-memory schema rather than the operation. This ensures that the operation is aware of any renames applied to the table or column by a preceding operation.
Ensure that the following sequence of operations in a migration works correctly: * Rename table * Rename column * Set unique constraint on the renamed column in the renamed table
andrew-farries
force-pushed
the
support-set-unique-in-multi-op-migrations
branch
from
57a9386 to
6a2c48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that multi-operation migrations combining
alter_columnoperations setting columns toUNIQUEworks in combination with other operations.Add testcases for:
Previously these migrations would fail as the
alter_columnoperation was unaware of the changes made by the preceding operation.Part of #239