Skip to content

Mark hidden commands in build-cli-definition tool #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

andrew-farries
Copy link
Collaborator

@andrew-farries andrew-farries commented May 20, 2025

Make the build-cli-definition tool not include hidden commands in the generated CLI definition JSON file.

Hidden commands are either internal (like anaylze) or work in progress (like baseline) and shouldn't be included in the generated CLI definition.

Updated based on #847 (review).

Make the build-cli-definition tool mark hidden commands in the generated JSON output.

@github-actions github-actions bot temporarily deployed to Docs Preview May 20, 2025 11:08 Inactive
@andrew-farries andrew-farries marked this pull request as ready for review May 20, 2025 11:13
@andrew-farries andrew-farries requested review from kvch and divyenduz May 20, 2025 11:13
Copy link
Contributor

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My preferred solution will be to add a hidden: true column though instead of removing. Having baseline structure before it is available will help with early integration.

Make the `build-cli-definition` tool mark hidden commands in the
generated JSON output.
@andrew-farries andrew-farries force-pushed the change-cli-definition-tool branch from 251850e to 40768f5 Compare May 20, 2025 11:25
@github-actions github-actions bot temporarily deployed to Docs Preview May 20, 2025 11:25 Inactive
@andrew-farries andrew-farries changed the title Ignore hidden commands in build-cli-definition tool Mark hidden commands in build-cli-definition tool May 20, 2025
@andrew-farries
Copy link
Collaborator Author

LGTM. My preferred solution will be to add a hidden: true column though instead of removing. Having baseline structure before it is available will help with early integration.

Let's do it that way then 👍

@andrew-farries andrew-farries requested a review from divyenduz May 20, 2025 11:28
@andrew-farries andrew-farries merged commit 1b31daa into main May 20, 2025
30 checks passed
@andrew-farries andrew-farries deleted the change-cli-definition-tool branch May 20, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants