Skip to content

Remove --name flag from pgroll convert #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

andrew-farries
Copy link
Collaborator

Remove the --name flag from the pgroll convert flag. Migration names should not be specified in migration files themselves, and the support for doing so will be removed as part of #715.

Update the documentation for the convert command to reflect the change.

Part of #715

It has no effect now that migration names are not deserialized.
Remove references to the removed `--name` flag
@github-actions github-actions bot temporarily deployed to Docs Preview May 21, 2025 11:13 Inactive
@andrew-farries andrew-farries marked this pull request as ready for review May 21, 2025 11:28
@andrew-farries andrew-farries requested a review from kvch May 21, 2025 11:28
@kvch
Copy link
Contributor

kvch commented May 21, 2025

Could you please update the ORM guide as well? It's in docs/guides/orms.mdx.

Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes can be done in a follow-up PR.

Remove the `--name` flag from the `pgroll convert` commands in the ORM
guide documentation. The flag is removed.
@github-actions github-actions bot temporarily deployed to Docs Preview May 21, 2025 12:07 Inactive
@andrew-farries
Copy link
Collaborator Author

Could you please update the ORM guide as well? It's in docs/guides/orms.mdx.

Thanks 👍 I made those changes here.

@andrew-farries andrew-farries merged commit 052ab79 into main May 21, 2025
30 checks passed
@andrew-farries andrew-farries deleted the remove-name-flag-from-convert branch May 21, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants